Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plumbing: format/packfile, prevent large objects from being read into memory completely #330

Merged
merged 6 commits into from Jun 30, 2021
Merged

plumbing: format/packfile, prevent large objects from being read into memory completely #330

merged 6 commits into from Jun 30, 2021

Commits on Jun 2, 2021

  1. Prevent large objects from being read into memory completely (take 2) 

    This PR adds code to prevent large objects from being read into memory
from packfiles or the filesystem.

Objects greater than 1Mb are now no longer directly stored in the cache
or read completely into memory.

This PR differs and improves the previous broken go-git#323 by fixing several
bugs in the reader and transparently wrapping ReaderAt as a Reader.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 2, 2021
    Copy the full SHA
    fa47367 View commit details
    Browse the repository at this point in the history

  2. add tests 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 2, 2021
    Copy the full SHA
    22550b6 View commit details
    Browse the repository at this point in the history

  3. prod CI

    @zeripath
    zeripath committed Jun 2, 2021
    Copy the full SHA
    a1fc3fc View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Don't add to the object cache

    @zeripath
    zeripath committed Jun 24, 2021
    Copy the full SHA
    1d722fd View commit details
    Browse the repository at this point in the history

  2. renudge CI

    @zeripath
    zeripath committed Jun 24, 2021
    Copy the full SHA
    fb6894b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Make the LargeObjectThreshold optional 

    This commit moves the LargeObjectThreshold into an option set on the
ObjectStorage. Unfortunately this means that the LOT has to percolate
down the calling tree.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 28, 2021
    Copy the full SHA
    85feea7 View commit details
    Browse the repository at this point in the history