Remote: new ListContext function #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiujuan95
force-pushed
the
timeout-ctx-ls-remote
branch
from
0c05bd3
to
2ffab4d
Compare
|
Does anyone know how can I re-run my tests directly rather than change my codes and push again. (Because these failed tests are not related with my changes) |
xiujuan95
force-pushed
the
timeout-ctx-ls-remote
branch
2 times, most recently
from
dd236a3
to
d8220e5
Compare
xiujuan95
changed the title
xiujuan95
force-pushed
the
timeout-ctx-ls-remote
branch
5 times, most recently
from
37bd7e1
to
44978de
Compare
|
Could anyone pls help review this PR? Maybe @mcuadros, can you help review it pls? Thanks in advance! |
|
Looks great can you rebase it? |
xiujuan95
force-pushed
the
timeout-ctx-ls-remote
branch
from
44978de
to
13be118
Compare
@mcuadros Sure, done! Please take a look again, thanks a lot! |
mcuadros
reviewed
Apr 19, 2021
go.sum
Outdated
| @@ -25,24 +25,16 @@ github.com/go-git/go-billy/v5 v5.0.0 h1:7NQHvd9FVid8VL4qVUMm8XifBK+2xCoZ2lSk0agR | |||
| github.com/go-git/go-billy/v5 v5.0.0/go.mod h1:pmpqyWchKfYfrkb/UVH4otLvyi/5gJlGI4Hb3ZqZ3W0= | |||
| github.com/go-git/go-billy/v5 v5.1.0 h1:4pl5BV4o7ZG/lterP4S6WzJ6xr49Ba5ET9ygheTYahk= | |||
| github.com/go-git/go-billy/v5 v5.1.0/go.mod h1:pmpqyWchKfYfrkb/UVH4otLvyi/5gJlGI4Hb3ZqZ3W0= | |||
| github.com/go-git/go-git-fixtures/v4 v4.0.1 h1:q+IFMfLx200Q3scvt2hN79JsEzy4AmBTp/pqnefH+Bc= | |||
There was a problem hiding this comment.
please don't update the go.sum
There was a problem hiding this comment.
@mcuadros May I know why?
There was a problem hiding this comment.
Because the purpose of this PR is to add the ListContext function not update the dependencies.
There was a problem hiding this comment.
I see, done! @mcuadros Please take a look again, thanks!
xiujuan95
force-pushed
the
timeout-ctx-ls-remote
branch
5 times, most recently
from
2867215
to
0cc02f5
Compare
xiujuan95
force-pushed
the
timeout-ctx-ls-remote
branch
from
0cc02f5
to
768c024
Compare
mcuadros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's from this discussion: #246 (comment)
When a user calls
go-gitpackage to dogit ls-remotecheck, we should provide a timeout. Otherwise, this will be stuck in some situation, and cause a controller which is usingListalway waits again and again.. This is not expected I think.This pull request add a
ListContextforListfunc and passcontext. For context, I set10stimeout. If exceed 10s, thenListfunc will exit. Maybe10sis too short, we can discuss a reasonable value about it.Also I add a unit test to test timeout case. Locally, all unit tests passed.