stage deleted files in doAddDirectory #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @hensur for this fix. I am also hit by this. Can this be merged ? |
|
Can you provide some tests? Thanks |
|
We need cover this with some test, to avoid hit again on this issue |
|
This looks like it was fixed in #652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into #223
This seems to fix the issue for deleted files.
Directories however, probably won't work correctly.
I'm happy to receive some feedback on this solution.
I might get around to implementing directories as well. Some further input on that would be great as well.
(partly) fixes #223