Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative submodule resolution #195

Merged
merged 1 commit into from Oct 30, 2020

Commits on Oct 28, 2020

  1. Fix relative submodule resolution

    With the current behavior, the config will always hold the resolved,
    absolute URL, leavin the user of go-git no choice to determine whether
    the original URL is relative or not.
    
    This changes to employ relative URL resolution only when resolving
    a submodule to a repository to keep the correct configuration
    'unresolved' and intact.
    
    Change relative resolution using `filepath.Dir` to `path.Join` while
    parsing both the 'root' and the relative URL with `net/url.URL`.
    
    Adapt test to verify the new behavior.
    
    Re-fixes go-git#184 (see comments).
    Axel Christ committed Oct 28, 2020
    Copy the full SHA
    81d429b View commit details
    Browse the repository at this point in the history