Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: dotgit, head reference usually comes first #1085

Merged
merged 2 commits into from Apr 28, 2024

Conversation

aymanbagabas
Copy link
Contributor

When reading the repository references from DotGit, the HEAD reference should always come first.

This mimics the behavior of git show-ref --head

When reading the repository references from DotGit, the HEAD reference
should always come first.

This mimics the behavior of `git show-ref --head`
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM, please just add a test to ascertain the refs order.

@aymanbagabas aymanbagabas requested a review from pjbgf April 27, 2024 17:49
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @aymanbagabas. 🙇

@pjbgf pjbgf merged commit bdb35e1 into go-git:master Apr 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants