git: Fix fetching missing commits #1032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Feb 21, 2024
|
Please add a new test which reproduces the issue you are experiencing. That test should fail without the changes this PR introduces. |
Signed-off-by: Arieh Schneier <15041913+AriehSchneier@users.noreply.github.com>
AriehSchneier
force-pushed
the
fix-failed-fetching
branch
from
c0c1ba3
to
cc5eb21
Compare
pjbgf
reviewed
Feb 22, 2024
Comment on lines
-854
to
-886
| if remoteRefs[h] { | ||
| haves[h] = true | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Would this not cause a performance regression, as we may be increasing the memory churn?
# Conflicts: # remote.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes fetching commits that have a reference to them but are not in the pack files.