git: Add support for deepening shallow clones #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohankmr414
pushed a commit
to rohankmr414/go-git
that referenced
this pull request
Oct 30, 2022
This reverts commit 320db9a.
rohankmr414
pushed a commit
to rohankmr414/go-git
that referenced
this pull request
Nov 3, 2022
This reverts commit 320db9a. Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
alexec
added a commit
to argoproj-labs/go-git
that referenced
this pull request
Nov 22, 2022
Revert "git: Add support for deepening shallow clones (go-git#311)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd previously get an error "object not found" when attempting to fetch a new depth on a shallow clone. This PR fixes the issue and adds a relevant test.
We could not get untouched tests to fully pass in our environment, with or without our changes. We're hoping your CI is properly configured to run the entire suite, if not we can investigate further.
Let me know if there are any changes you'd like to see before accepting this PR.
Thanks!