New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getting empty git-upload-pack given
from wf using git artifacts as input
#9613
Comments
@caelan-io and @JPZ13 Do you like to submit PR for this? |
Hey @sarabala1979 , I opened this issue as it was reported by someone in Slack. It's not specific to us. I'm unsure how high priority it is compared to other issues we're already working on. Let's discuss at the contributor meeting, or let us know what list of 3.4 release issues you're working through and need support on. |
We are getting this issue as well |
Do we support |
Also, be aware of that we actually use a fork: Line 226 in d9d1968
|
We are also currently experiencing this issue. We are using Argo Workflows as a CI solution, so we need to check out from a specific commit and use shallow cloning. Also like any breaking change, dropping |
This issue needs more information:
|
This was working before v3.4.0, fairly certain it is occurring in v3.4.1 as well. |
The version I am currently testing is 3.4.1 The issue I am experiencing matches exactly with go-git/go-git#328. @alexec Here are the init logs of such a failing workflow pod:
|
|
In v3.4 we switched from using |
Please attach a workflow that repos this issue. |
A work-around for this would be to use an init container to check out the code onto a shared volume. I'm not sure how you bring in secrets. |
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: git-
spec:
entrypoint: main
templates:
- name: main
volumes:
- name: wd
emptyDir: { }
initContainers:
- name: checkout
image: alpine/git
volumeMounts:
- mountPath: /wd
name: wd
workingDir: /wd
command:
- git
args:
- clone
- --depth=1
- https://github.com/argoproj/argo-workflows.git
container:
image: ubuntu
volumeMounts:
- mountPath: /wd
name: wd
workingDir: /wd
command:
- ls |
|
Ok. Next steps for anyone wanting to investigate:
|
We are waiting on argoproj-labs/go-git#5 now to be merged and see if it makes a difference once the dependency gets bumped again. |
I was able to make it work using these values in argo-workflows helm chart:
|
This bug was caused after the commit go-git/go-git@320db9a on the go-git upstream. This commit was supposed to allow us to fetch a new depth on a shallow clone (more details here go-git/go-git#311). Since we only use this to fetch artifacts and we do not revise the depth of a clone in our workflows, it's safe to revert this. Reverting this commit fixes the bug (tested on my local), I've opened a PR argoproj-labs/go-git#6 on our fork to revert this commit. cc: @sarabala1979 @alexec |
We need some help here. We’d like to look at alternatives to Could someone please volunteer? |
Summary
What happened/what you expected to happen?
argo-workflows/workflow/artifacts/git/git.go
Line 155 in 047952a
empty git-upload-pack given
errors since v5.4.0 go-git/go-git#328 (comment)What version are you running?
v3.4
Diagnostics
Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: