Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang.org/x/crypto/openpgp is deprecated #282

Closed
johanfleury opened this issue Apr 2, 2021 · 2 comments · Fixed by #283
Closed

golang.org/x/crypto/openpgp is deprecated #282

johanfleury opened this issue Apr 2, 2021 · 2 comments · Fixed by #283

Comments

@johanfleury
Copy link
Contributor

Hey, just wanted to share that golang.org/x/crypto/openpgp is deprecated (see golang/go#44226 for details).

There are a few forks, mainly:

Migrating to one of these projects doesn’t seem too hard as they are forks of the original go-crypto repository.

@johanfleury
Copy link
Contributor Author

BTW, I think (but I can’t be sure) that ProtonMail’s fork supports Ed25519, which mean it would be possible to verify commit signed with that key type.

Currently, commit.Verify returns this error openpgp: unsupported feature: public key type: 22.

@johanfleury
Copy link
Contributor Author

johanfleury commented Apr 2, 2021

BTW, I think (but I can’t be sure) that ProtonMail’s fork supports Ed25519, which mean it would be possible to verify commit signed with that key type.

I tested while making #283 and can confirm that Ed25519 keys are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant