Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed25519 keys are not supported for GPG signatures #331

Closed
johanfleury opened this issue Apr 2, 2021 · 1 comment
Closed

Ed25519 keys are not supported for GPG signatures #331

johanfleury opened this issue Apr 2, 2021 · 1 comment

Comments

@johanfleury
Copy link

Hi,

Just wanted to share that Ed25519 keys are not supported for GPG signatures.

This is a limitation of golang.org/x/crypto/openpgp (used by go-git) which is deprecated anyway. I’ve opened an issue and made a PR on go-git to change the openpgp provider (see go-git/go-git#282 and go-git/go-git#283).

Meanwhile, I’m opening this issue in the hope it can help people who are debugging why source-controller prints messages like this one when the signature is completely valid:

{"level":"error","ts":"2021-04-02T21:27:22.111Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"main","namespace":"flux","error":"PGP signature '[SNIPPED]' of '[SNIPPED]' can't be verified"}

Hopefully the PR on go-git can get merged soon and you’ll be able to update the dependency.

@hiddeco
Copy link
Member

hiddeco commented May 27, 2021

This should have been solved in the latest release via #365

@hiddeco hiddeco closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants