Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix event-and-action #420

Merged
merged 2 commits into from
May 6, 2024

Conversation

nkmr-jp
Copy link
Contributor

@nkmr-jp nkmr-jp commented May 5, 2024

Description

Hello! The go sample code on the 'Event And Action' page of the document was incorrect, so I fixed it.

https://go-echarts.github.io/go-echarts/#/en-us/event-and-action?id=action
image


Type of change

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Would cause existing functionality to not work as expected)
  • Docs
  • Others

@nkmr-jp nkmr-jp marked this pull request as draft May 5, 2024 04:15
@nkmr-jp nkmr-jp marked this pull request as ready for review May 5, 2024 04:23
@nkmr-jp nkmr-jp changed the title Fix docs event-and-action docs: fix event-and-action May 5, 2024
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Koooooo-7 Koooooo-7 merged commit 6e5c28f into go-echarts:master May 6, 2024
5 checks passed
@nkmr-jp nkmr-jp deleted the fix-docs-event-and-action branch May 7, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants