Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function name in comment #417

Closed
wants to merge 1 commit into from

Conversation

largemouth
Copy link

@largemouth largemouth commented Apr 22, 2024

Description

Please share your ideas and awesome changes to let us know more :)

fix function name in comment


Type of change

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Would cause existing functionality to not work as expected)
  • Docs
  • Others

Signed-off-by: largemouth <largemouth@aliyun.com>
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your input here. Sorry that I suppose this kinda typo fix is tricky to be here.

@@ -325,7 +325,7 @@ func WithLineChartOpts(opt opts.LineChart) SeriesOpts {
}
}

// WithLineChartOpts sets the LineChart option.
// WithKlineChartOpts sets the LineChart option.
func WithKlineChartOpts(opt opts.KlineChart) SeriesOpts {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the typo fix, it seems strange for me here since the crude LineChart option is still exist.

@Koooooo-7 Koooooo-7 closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants