Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added MarkAreaDataItem #288

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

added MarkAreaDataItem #288

wants to merge 5 commits into from

Conversation

mwlazlo
Copy link

@mwlazlo mwlazlo commented Jun 4, 2023

Description

Previous implementation does not support markArea very well. It would render like this:

  "markArea": {
    "data": [
      {
        "name": "ref",
        "yAxis": 7023
      },
      {
        "yAxis": 6996
      }
    ]
  }

When was was needed was this:

  "markArea": {
    "data": [
      [
        {
          "name": "ref",
          "yAxis": 7023
        },
        {
          "yAxis": 6996
        }
      ]
    ]
  }

This PR tries to implement a more flexible data structure, allowing the user to create configurations closer to the documentation: https://echarts.apache.org/en/option.html#series-candlestick.markArea.data

Type of change

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Would cause existing functionality to not work as expected)
  • Others

Examples:

Are you willing to submit a PR on go-echarts/Examples?

  • Yes, I am willing to submit a PR on Examples!

@Koooooo-7 Koooooo-7 added need investigation Need investigation about this issue enhancement New feature or request labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need investigation Need investigation about this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants