Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More customizations for Line chart and Candlestick chart #278

Merged
merged 7 commits into from
Apr 4, 2023
Merged

More customizations for Line chart and Candlestick chart #278

merged 7 commits into from
Apr 4, 2023

Conversation

shmarlovsky
Copy link
Contributor

@shmarlovsky shmarlovsky commented Mar 22, 2023 •
edited

Koooooo-7
Koooooo-7 requested changes Apr 2, 2023
View reviewed changes
opts/charts.go Outdated Show resolved Hide resolved
@Koooooo-7
Copy link
Member

LGTM.
Hi @shmarlovsky , thx for this, could you plz update the examples with the new config (\ a new line chart with symbol option is also fine).

@Koooooo-7 Koooooo-7 merged commit 56edc0f into go-echarts:master Apr 4, 2023
1 check passed
@shmarlovsky
Copy link
Contributor Author

@Koooooo-7 Here is the PR with example with symbol options
go-echarts/examples#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koooooo-7 Koooooo-7 Koooooo-7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shmarlovsky @Koooooo-7