Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build.sh help text #274

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Fix build.sh help text #274

merged 2 commits into from
Mar 31, 2023

Conversation

r2p2
Copy link
Contributor

@r2p2 r2p2 commented Mar 13, 2023

Since arguments are checked with $1, adding --cmd like suggested in the help text would require the use of $2.

Koooooo-7
Koooooo-7 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Koooooo-7 Koooooo-7 merged commit 2e04a44 into go-echarts:master Mar 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koooooo-7 Koooooo-7 Koooooo-7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r2p2 @Koooooo-7