feat/page-opts: add option to override page opts #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudgl
reviewed
Apr 2, 2021
| opt(p) | ||
| } | ||
| return p | ||
| } |
There was a problem hiding this comment.
@AndreZiviani Sorry to interfere like this, i forked it and i see you made the same changes. You can add Layout options ass well
func WithLayoutOpts(l Layout) PageOpts {
return func(p *Page) {
p.Layout = l
}
}| @@ -30,6 +30,22 @@ type Page struct { | |||
| Layout Layout | |||
| } | |||
|
|
|||
| type PageOpts func(p *Page) | |||
|
|
|||
| func (p *Page) SetPageOptions(opts ...PageOpts) *Page { | |||
There was a problem hiding this comment.
@AndreZiviani Also i think you can add the opts in the Page's constructor it wont break anything
|
closed via #357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use the upstream lib (https://go-echarts.github.io/go-echarts-assets/assets/echarts.min.js) instead of the forked (https://go-echarts.github.io/go-echarts-assets/assets/echarts.min.js) using the
AssetsHostoption inInitializationstruct.The problem is that
page := components.NewPage()creates a page with default options (and do not have an option to override them), so when I added a chart usingpage.AddCharts(my_chart)theAssetsHostoption configured in the chart is ignored. Since we can have multiple graphs per page I thought that the best way to fix this is to implement an options system like the one used in charts.I think only the option
AssetsHostis usefull in the page context, maybe create a new struct with only this option?If anyone have a better idea please leave a comment