Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependencies #857

Merged
merged 3 commits into from
May 23, 2019
Merged

fix dependencies #857

merged 3 commits into from
May 23, 2019

Conversation

quasilyte
Copy link
Member

Refs quasilyte/go-consistent#34

Signed-off-by: Iskander Sharipov quasilyte@gmail.com

Refs quasilyte/go-consistent#34

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
@coveralls
Copy link

coveralls commented May 23, 2019

Coverage Status

Coverage remained the same at 97.845% when pulling 953fd72 on quasilyte/fixDeps into f6f702b on master.

Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
cristaloleg previously approved these changes May 23, 2019
go.mod Outdated
@@ -1,16 +1,17 @@
module github.com/go-critic/go-critic

go 1.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.13
go 1.12

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use go 1.12 to re-generate those files. :)

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
@quasilyte quasilyte merged commit 07bf84d into master May 23, 2019
@quasilyte quasilyte deleted the quasilyte/fixDeps branch May 23, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants