Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README install instruction for go 1.18 #1254

Merged
merged 1 commit into from Aug 25, 2022

Conversation

Faagerholm
Copy link
Contributor

As of go 1.18 go get outside of a module is deprecated, we should use go install instead.
This PR adds a small note on this for new users who wish to download go-critic

Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Faagerholm Faagerholm closed this Aug 25, 2022
@Faagerholm Faagerholm reopened this Aug 25, 2022
@cristaloleg cristaloleg changed the title Update README install instruction for go 1.18 docs: update README install instruction for go 1.18 Aug 25, 2022
@cristaloleg cristaloleg merged commit 5c89720 into go-critic:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants