Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add time range expr simplify #1220

Merged
merged 6 commits into from Apr 29, 2022
Merged

add time range expr simplify #1220

merged 6 commits into from Apr 29, 2022

Conversation

peakle
Copy link
Contributor

@peakle peakle commented Apr 15, 2022

cristaloleg
cristaloleg previously approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

quasilyte
quasilyte reviewed Apr 15, 2022
View reviewed changes
checkers/rules/rules.go Outdated Show resolved Hide resolved
cristaloleg
cristaloleg previously approved these changes Apr 16, 2022
View reviewed changes
@peakle peakle requested a review from quasilyte April 16, 2022 14:04
quasilyte
quasilyte previously approved these changes Apr 29, 2022
View reviewed changes
@quasilyte quasilyte merged commit bf8c01c into go-critic:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

@cristaloleg cristaloleg cristaloleg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peakle @cristaloleg @quasilyte