made go-critic's rules exportable #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But why? |
quasilyte
reviewed
Jan 10, 2022
checkers/rules/rules.go
Outdated
| @@ -4,6 +4,9 @@ import ( | |||
| "github.com/quasilyte/go-ruleguard/dsl" | |||
| ) | |||
|
|
|||
| // Bundle - used to import rules by external packages | |||
| var Bundle = dsl.Bundle{} | |||
There was a problem hiding this comment.
Unfortunately, we're using rules embedding in go-critic for builtin rules.
This means we can't export rules normally:
quasilyte/go-ruleguard#355
This is not a hard issue to fix in ruleguard, but right now it's not an option to use bundle vars in linters that use a precompile step.
|
We really need docker (or whatever) tests to check that gocritic can work without installed dsl dependency for the cases where custom ruleguard rules are not needed. Embedded rules should not require dsl package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.