checkers: rename undefinedFormatting to dynamicFmtString (#1174)

checkers/rules/rules.go

@@ -718,17 +718,17 @@ func emptyDecl(m dsl.Matcher) {
 	m.Match(`type()`).Report(`empty type() block`)
 }
 
-//doc:summary Detects bad usage of fmt.Errorf
-//doc:tags    diagnostic experimental opinionated
-//doc:before  fmt.Errorf(xs)
-//doc:after   fmt.Errorf("%s", xs)
-func undefinedFormatting(m dsl.Matcher) {
+//doc:summary Detects suspicious formatting strings usage
+//doc:tags    diagnostic experimental
+//doc:before  fmt.Errorf(msg)
+//doc:after   fmt.Errorf("%s", msg)
+func dynamicFmtString(m dsl.Matcher) {
 	m.Match(`fmt.Errorf($f)`).
 		Where(!m["f"].Const).
 		Suggest("errors.New($f)").
 		Report(`use errors.New($f) or fmt.Errorf("%s", $f) instead`)
 
 	m.Match(`fmt.Errorf($f($*args))`).
 		Suggest("errors.New($f($*args))").
-		Report(`use errors.New($f($*args)) or fmt.Errorf("%s",$f($*args)) instead`)
+		Report(`use errors.New($f($*args)) or fmt.Errorf("%s", $f($*args)) instead`)
 }