checkers: add io.WriteString patterns to preferFprint (#1180)

go-critic · Dec 31, 2021 · b7720e1 · b7720e1
1 parent 27e5601
commit b7720e1
Show file tree

Hide file tree

Showing 3 changed files with 342 additions and 299 deletions.
diff --git a/checkers/rules/rules.go b/checkers/rules/rules.go
@@ -363,6 +363,10 @@ func preferFprint(m dsl.Matcher) {
 		Where(m["w"].Type.Implements("io.Writer")).
 		Suggest("fmt.Fprintln($w, $args)").
 		Report(`fmt.Fprintln($w, $args) should be preferred to the $$`)
+
+	m.Match(`io.WriteString($w, fmt.Sprint($*args))`).Suggest(`fmt.Fprint($w, $args)`)
+	m.Match(`io.WriteString($w, fmt.Sprintf($*args))`).Suggest(`fmt.Fprintf($w, $args)`)
+	m.Match(`io.WriteString($w, fmt.Sprintln($*args))`).Suggest(`fmt.Fprintln($w, $args)`)
 }
 
 //doc:summary Detects suspicious duplicated arguments