checkers: add At() for httpNoBody checker (#1164)

go-critic · Dec 7, 2021 · 9463ac1 · 9463ac1
1 parent e394bba
commit 9463ac1
Show file tree

Hide file tree

Showing 3 changed files with 532 additions and 527 deletions.
diff --git a/checkers/checkers_test.go b/checkers/checkers_test.go
@@ -199,7 +199,7 @@ func TestExternal(t *testing.T) {
 			continue
 		}
 		if diff := cmp.Diff(want, have); diff != "" {
-			t.Errorf("%s output mismatches:\n%s", proj.Name(), diff)
+			t.Errorf("%s output mismatches (+have -want):\n%s", proj.Name(), diff)
 			continue
 		}
 	}

diff --git a/checkers/rules/rules.go b/checkers/rules/rules.go
@@ -118,12 +118,14 @@ func httpNoBody(m dsl.Matcher) {
 	m.Match("http.NewRequest($method, $url, $nil)").
 		Where(m["nil"].Text == "nil").
 		Suggest("http.NewRequest($method, $url, http.NoBody)").
-		Report("http.NoBody should be preferred to the nil request body")
+		Report("http.NoBody should be preferred to the nil request body").
+		At(m["nil"])
 
 	m.Match("http.NewRequestWithContext($ctx, $method, $url, $nil)").
 		Where(m["nil"].Text == "nil").
 		Suggest("http.NewRequestWithContext($ctx, $method, $url, http.NoBody)").
-		Report("http.NoBody should be preferred to the nil request body")
+		Report("http.NoBody should be preferred to the nil request body").
+		At(m["nil"])
 }
 
 //doc:summary Detects expressions like []rune(s)[0] that may cause unwanted rune slice allocation