checkers: micro optimizes (#1194)

go-critic · Jan 15, 2022 · 319a0d4 · 319a0d4
1 parent f0a10a0
commit 319a0d4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/checkers/boolExprSimplify_checker.go b/checkers/boolExprSimplify_checker.go
@@ -1,7 +1,6 @@
 package checkers
 
 import (
-	"fmt"
 	"go/ast"
 	"go/token"
 	"strconv"
@@ -295,7 +294,7 @@ func (c *boolExprSimplifyChecker) foldRanges(cur *astutil.Cursor) bool {
 			if match(&comb) {
 				lhs.Op = token.EQL
 				v := c1 + comb.resDelta
-				lhs.Y.(*ast.BasicLit).Value = fmt.Sprint(v)
+				lhs.Y.(*ast.BasicLit).Value = strconv.FormatInt(v, 10)
 				cur.Replace(lhs)
 				return true
 			}
@@ -317,7 +316,7 @@ func (c *boolExprSimplifyChecker) foldRanges(cur *astutil.Cursor) bool {
 			if match(&comb) {
 				lhs.Op = token.NEQ
 				v := c1 + comb.resDelta
-				lhs.Y.(*ast.BasicLit).Value = fmt.Sprint(v)
+				lhs.Y.(*ast.BasicLit).Value = strconv.FormatInt(v, 10)
 				cur.Replace(lhs)
 				return true
 			}

diff --git a/checkers/regexpSimplify_checker.go b/checkers/regexpSimplify_checker.go
@@ -8,9 +8,10 @@ import (
 	"strings"
 	"unicode/utf8"
 
+	"github.com/quasilyte/regex/syntax"
+
 	"github.com/go-critic/go-critic/checkers/internal/astwalk"
 	"github.com/go-critic/go-critic/framework/linter"
-	"github.com/quasilyte/regex/syntax"
 )
 
 func init() {
@@ -497,9 +498,9 @@ func (c *regexpSimplifyChecker) simplifyCharRange(rng syntax.Expr) string {
 		case 0:
 			return lo
 		case 1:
-			return fmt.Sprintf("%s%s", lo, hi)
+			return lo + hi
 		case 2:
-			return fmt.Sprintf("%s%s%s", lo, string(lo[0]+1), hi)
+			return lo + string(lo[0]+1) + hi
 		}
 	}
 

diff --git a/framework/lintmain/internal/lintdoc/doc.go b/framework/lintmain/internal/lintdoc/doc.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"os"
+	"reflect"
 	"text/template"
 
 	"github.com/go-critic/go-critic/framework/linter"
@@ -71,7 +72,7 @@ Checker parameters:
 	templateData.Checker = info
 	templateData.ParamTypes = make(map[string]string)
 	for pname, p := range info.Params {
-		templateData.ParamTypes[pname] = fmt.Sprintf("%T", p.Value)
+		templateData.ParamTypes[pname] = reflect.TypeOf(p.Value).String()
 	}
 
 	tmpl := template.Must(template.New("doc").Parse(tmplString))

diff --git a/framework/linttest/integration.go b/framework/linttest/integration.go
@@ -74,7 +74,7 @@ func (cfg *IntegrationTest) runTest(t *testing.T, gocritic, gopath string) {
 			if err != nil {
 				t.Errorf("read golden file: %v", err)
 			}
-			want = strings.TrimSpace(string(data))
+			want = string(bytes.TrimSpace(data))
 			goldenDataCache[goldenFile] = want
 		}