add new warnings

go-critic · Oct 24, 2021 · 582fba0 · 582fba0
1 parent 1fc2945
commit 582fba0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/projects/packr/builder/builder.go b/projects/packr/builder/builder.go
@@ -75,7 +75,7 @@ func (b *Builder) Run() error {
 }
 
 func (b *Builder) dump() error {
-	dumpPkg := func(p pkg) error {
+	for _, p := range b.pkgs {
 		name := filepath.Join(p.Dir, "a_"+p.Name+"-packr.go")
 		f, err := os.Create(name)
 		defer f.Close()
@@ -91,13 +91,6 @@ func (b *Builder) dump() error {
 		if err != nil {
 			return err
 		}
-		return nil
-	}
-
-	for _, p := range b.pkgs {
-		if err := dumpPkg(p); err != nil {
-			return err
-		}
 	}
 	return nil
 }

diff --git a/projects/packr/output.golden b/projects/packr/output.golden
@@ -24,3 +24,4 @@ exit status 1
 ./builder/builder_test.go:38:12: ioutilDeprecated: ioutil.ReadFile is deprecated, use os.ReadFile instead
 ./builder/builder_test.go:63:13: ioutilDeprecated: ioutil.ReadFile is deprecated, use os.ReadFile instead
 ./builder/builder_test.go:68:12: ioutilDeprecated: ioutil.ReadFile is deprecated, use os.ReadFile instead
+./builder/builder.go:81:3: deferInLoop: Possible resource leak, 'defer' is called in the 'for' loop