relax types for Bind and Render funcs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relaxes the Bind and Render to accept any type as a payload. If those types implement the Binder or Renderer interfaces, then the relevant method on the type is called. Sometimes the default Bind or Render behavior is sufficient, and I don't need any additional custom handling. Return early if payload value is nil. Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/bind-render
branch
from
fefc22c
to
988c2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the Bind and Render to accept any type as a payload. If those types implement the Binder or Renderer interfaces, then the relevant method on the type is called. Sometimes the default Bind or Render behavior is sufficient, and I don't need any additional custom handling.
It looks like the Bind method was updated in #38 but that PR was immediately closed, but I'm not sure why.