Bugfix/log entry set fields #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
approved these changes
Apr 16, 2024
| attrs := make([]slog.Attr, len(fields)) | ||
| attrs := make([]any, len(fields)) |
There was a problem hiding this comment.
*entry.Logger.With(attrs...) has the following signature:
func (l *Logger) With(args ...any)
…g arguments correctly
Without the change in this changeset, running `go test` fails with:
```
./httplog.go:361:37: slog.Logger.With arg "attrs" should be a string or a slog.Attr (possible missing key or value)
FAIL
```
This is due to the fact that the array of `slog.Attr`s was supplied as
a single arg (i.e. a single slice of attributes) to
`*entry.Logger.With`, instead of a variable number of arguments.
Example:
```go
fields := map[string]any{
"remote": "example.com",
"action": "update",
}
httplog.LogEntrySetFields(ctx, fields)
```
Without this change, the updated example that uses LogEntrySetFields
creates the following log entry:
```
user: "user1" !BADKEY: [remote=example.com action=update]
```
With the change the log line for the updated example is:
```
user: "user1" remote: "example.com" action: "update"
```
stefansaasen
force-pushed
the
bugfix/log-entry-set-fields
branch
from
973b3db
to
dae0025
Compare
|
Updated the PR to incorporate the latest changes from |
AnomalRoil
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogEntrySetFields: Use the varargs syntax to supply the additional log arguments correctlyWithout the change in this changeset, running
go testfails with:This is due to the fact that the array of
slog.Attrs was supplied asa single arg (i.e. a single slice of attributes) to
*entry.Logger.With, instead of a variable number of arguments.Example:
Without this change, the updated example that uses LogEntrySetFields
creates the following log entry:
With the change the log line for the updated example is: