Removes ambiguity around "fresh middleware stack" in GoDoc #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Group():freshimplies that a new empty middleware stack is created, while in fact the parent's stack is copied.For
Route():Looks like
with a fresh middleware stackwas added to emphasize that while the parent middleware stack is frozen, one can still add middlewares to new router's stack before starting to define routes on it.In my opinion this is clear from
creates a new Mux. Addingwith a fresh middleware stackmakes it more obscure that the parent middleware stack will be executed wrapping the new one.