Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for nil RouteContext in URLFormat #841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Taaipi
Copy link

@Taaipi Taaipi commented Aug 10, 2023

Fix #839
Ref #718

In the current URLFormat middleware implementation, when rctx (Route Context) is nil, it could lead to unexpected behavior or panic errors in subsequent processing.

To avoid this, I have prioritized not allowing unexpected behavior by implementing error handling for the cases where rctx is missing or nil. Now, instead of failing silently or causing a panic error, the system will return a proper HTTP error response.

This change ensures that the system behaves consistently and avoids potential pitfalls that might arise from missing or improperly initialized rctx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic if rctx is nil
1 participant