Make CleanPath middleware work with other routers #786
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
requested changes
Feb 5, 2023
| } | ||
|
|
||
| rctx.RoutePath = path.Clean(routePath) |
There was a problem hiding this comment.
wont it panic on this line if rctx is nil..? and this PR changes the logic of the method as well, calling path.Clean() more often then previously
|
in #787 @romain-tadiello says
I'm not sure but this might be relevant to why he moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rctx is not checked and could be nil if the function isn't used with a chi.Router.
It ends up in a panic.
Additional point: the cleaning only happens in the rctx.RoutePath is an empty string. If a function like GetHead ¶ is called before it won't clean the path.