Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConfigFix] Add 'PyYAML==5.4.1' version in 'functional3' tox env #56

Merged
merged 1 commit into from Nov 16, 2021
Merged

[ConfigFix] Add 'PyYAML==5.4.1' version in 'functional3' tox env #56

merged 1 commit into from Nov 16, 2021

Conversation

vamahaja
Copy link
Collaborator

Latest version of PyYAML [> 5.4.1], yaml.load(f) is deprecated in favour of yaml.load(f, Loader=loader). This causing below error while using functional3 tox env

File "/usr/local/lib/python3.6/site-packages/glusto/configurable.py", line 215, in _load_yaml
config = yaml.load(configfd)
TypeError: load() missing 1 required positional argument: 'Loader'

Refer - yaml/pyyaml#576

srivickynesh
srivickynesh approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@srivickynesh srivickynesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adityaramteke
adityaramteke approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@adityaramteke adityaramteke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aloganat
aloganat approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vamahaja vamahaja merged commit 50148d3 into gluster:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloganat aloganat aloganat approved these changes

@adityaramteke adityaramteke adityaramteke approved these changes

@srivickynesh srivickynesh srivickynesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vamahaja @aloganat @adityaramteke @srivickynesh