Allow tab content to be opened using middle click #17156
Conversation
|
Full page tabs are an old debug feature. Not sure they serve much of a purpose anymore and the warning message doesn't seem to trigger anymore. |
Done in #17157 . |
| // TODO: ctrl+click should have the same behavior but it seems | ||
| // to be caught by the tabs events handler and does not trigger | ||
| // a new browser tab. |
There was a problem hiding this comment.
Clicks default behaviour are prevented by the bootstrap tabs logic. The only way to handle this is to remove the data-bs-toggle='tab' attribute and add a click handler that either let the default behaviour continue when e.ctrlKey === true, either trigger the tab display manually.
There was a problem hiding this comment.
Yeah, I am not sure it is worth dealing with right now as it doesn't break anything.
Issue
Opening an item tab using the middle click lead to a broken "raw" page:
This is because our tabs
hrefproperties are the ajax endpoinst that will fetch the data.So, opening the link in a new tab will only fetch the tab content and nothing else.
Fix
This is easy to fix as we have no requirement to use this url directly in the
hrefproperty.We can use a valid
hrefand move the ajax endpoints URL into dedicated data attributes.Tests
2E tests can't be added to validate this as cypress does not support multiple browsers tabs.
Branch
I'm doing this changes in main because the
hrefproperty may possibly be parsed by some plugins which would break with this change.If you think this possible issue is too "far fetched", I can move the PR to target the bugfix branch instead.