-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): Adding dropdown category and related sub question type #17126
base: main
Are you sure you want to change the base?
feat(forms): Adding dropdown category and related sub question type #17126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small bugs I've found:
1) Wrong input name
Should be answers_141 since we switched to the new format.
This mean answers are not taken into account for this question type.
2) Invalid order
It seems the dropdown is not refreshed after options order are modified using drag and drop.
The "old" order is still displayed until we do another action like changing the default value.
c5ced17
to
bd6fc60
Compare
(opinion based on the provided screenshots) I think in this particular case, you should not decorate options at all. More, there is the drag icon, so 2 icons on the left of the options Ideas for alternative ux:
|
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
The decoration input has been hidden, so the tests related to the radio/checkbox check was deleted. The only way to set an option has a default value is to select one or more options in the preview dropdown
Added
Dropdown
category and related sub-question type :Dropdown
Form editor view :
Form end user view :