Fix for jumping input bar in Safari #986
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm testing on mobile safari this messes up page height adjustment but fixes some issues I’ve been having with the cursor being misaligned in the input bar on iOS 11. The window still jumps to the top when I send a message (more precisely, when the message I sent is received again). |
|
Now I’ve still got the jumpiness and the input bar blocks more space than it needs (it extends too far up). Got any ideas how to fix that? Thanks btw for taking a shot at our issues with Safari, it’s much appreciated! :) |
|
Hey @forberg, I just tried this in Chrome 65 on the Desktop and it messes up the input bar placement (it's floating a bit too high but a little different in every buffer, it seems). Are you sure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue: #836 (comment)