Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/playing around]Add ability to show filtered lines with Alt+= #897

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lorenzhs
Copy link
Member

@lorenzhs lorenzhs commented Feb 9, 2017

Still needs lots of work:

  • measure performance impact. Non-starter if noticeable.
  • fix toggle jiggle. Should probably keep the topmost line in the same position as before or whatever WeeChat does.
  • rethink line discarding logic. Since we now store filtered lines, we might throw away too many when switching buffers only to fetch them anew a moment later
  • Check whether readmarker works properly

Still needs lots of work:
- measure performance impact. Non-starter if noticeable.
- fix readmarker. Haven't thought about that at all yet.
- fix toggle jiggle. Should probably keep the topmost line in the same
  position as before or whatever WeeChat does.
@Vaesper
Copy link
Contributor

Vaesper commented Feb 9, 2017

How would you use this on mobile?

@lorenzhs
Copy link
Member Author

lorenzhs commented Feb 9, 2017

Well it does say "WIP/playing around" in the title :) It's not done yet, but I made a PR so anyone can test and play around with it on https://latest.glowing-bear.org/pull/897/

@Vaesper
Copy link
Contributor

Vaesper commented Feb 9, 2017

Sure, just figured I should point out that that's also a thing to consider :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants