Fix mobile layout: horizontal scrollbars (FF) and td alignment #843
Conversation
|
Oh and for sake of clarity; the css changes are to "undo" the |
Vaesper
force-pushed
the
bufferlines-on-mobile
branch
from
82e1dad
to
832f19a
Compare
|
When I test this PR I get an extra space between the prefix and the line. Maybe that's what the HTML comments fixes? I don't enjoy that extra space. |
|
Hm appears that way, given the wording of #491? |
|
I think that this whitespace should be attributed to the table-cell padding that is not removed when switching to |
Vaesper
force-pushed
the
bufferlines-on-mobile
branch
3 times, most recently
from
1ba1f3e
to
ae8ad4c
Compare
Vaesper
force-pushed
the
bufferlines-on-mobile
branch
2 times, most recently
from
9a91643
to
ceee0d6
Compare
css/glowingbear.css
Outdated
| display: block; | ||
| flex-wrap: wrap; |
There was a problem hiding this comment.
you're mixing tabs and spaces here - just a heads up :)
There was a problem hiding this comment.
argh, stupid editors. thanks for the heads-up
Vaesper
force-pushed
the
bufferlines-on-mobile
branch
from
bac6426
to
f2b4e99
Compare
|
@torhve you're either going to love me or hate me for what I've done to mobile layout this time :D |
Vaesper
force-pushed
the
bufferlines-on-mobile
branch
6 times, most recently
from
8da7f3f
to
166bebe
Compare
|
Found some weirdness where the re-ordering of the prefix and timestamp was messed up on some lines on FF mobile. Same bufferline worked fine on FF desktop with the mobile layout, and I have not yet managed to get remote debugging working so not sure what's going on. |
|
Hey @Vaesper what's the status on this? I've been using it on mobile (iOS) for a while and really like it |
|
My weechat box has been offline for a few weeks due to moving and my lack of time to set it up again, but before that I've been using this branch almost exclusively on my phone and never managed to reproduce that weird timestamp/prefix reordering bug (or even see it again). It needs to be rebased to master (18 commits behind) and checked that it still works, but github reports no conflicts so at least the rebase should just be a fastforward. |
Vaesper
force-pushed
the
bufferlines-on-mobile
branch
from
166bebe
to
62411e3
Compare
|
Cannot test it myself right now due to lack of weechat as mentioned previously, but I've gone ahead and rebased the branch. Let me know if things are now (horribly) broken :D |
|
Tested it, and everything works as expected :) |
lorenzhs
force-pushed
the
bufferlines-on-mobile
branch
from
62411e3
to
4ceb7a3
Compare
|
I rebased this onto master so I can keep using it on my phone without missing out :) |
lorenzhs
force-pushed
the
bufferlines-on-mobile
branch
from
4ceb7a3
to
7568918
Compare
Okay, once again, please verify that I'm not a complete lunatic and test this on systems I have no access to. Tested: FF 49 and Chromium 53 on linux.
So the HTML fix... Is a complete revert of commit a1f6012. I'm not sure what was going on there, but as far as I can tell there currently is no (and at the time of that commit there was no)
white-space: preapplied outside of thetd.prefix.Allowing the whitespace fixes not only horizontal scrollbars on FF with the mobile layout, but ALSO fixes something I'd noticed in both FF and Chromium; the fact that the prefix is kept on the same line as the message, both UNDER the timestamp when the message starts with a long string. This does not make any sense to me, if there's a long unbreakable string at the start of the message (someone posting a link?) I'd want the timestamp and prefix to be on the same line at least.
Long story short, I have no idea what I'm doing but it seems to work. Pls check.