Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEEDBACK] Implement buffer history for alt+a and alt+<, alt+>, and alt+/ #449

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FEEDBACK] Implement buffer history for alt+a and alt+<, alt+>, and alt+/ #449

wants to merge 3 commits into from

Conversation

lorenzhs
Copy link
Member

Fixes #360 and adds a couple of new features :)

@lorenzhs
Copy link
Member Author

the keyboard shortcut part of this needs a lot of testing, that stuff sucks :(

I can't get meaningful events for alt+< and alt+> with QWERTZ at all, and with Neo2, alt+> conflicts with alt+g because < is mod3+g in neo :\

@lorenzhs
Copy link
Member Author

What do you guys think about the direction this is heading in?

@lorenzhs
Copy link
Member Author

Comments on this?

@lorenzhs lorenzhs changed the title [WIP/PLS TEST] Implement buffer history for alt+a and alt+<, alt+>, and alt+/ [FEEDBACK] Implement buffer history for alt+a and alt+<, alt+>, and alt+/ Oct 21, 2014
@lorenzhs lorenzhs mentioned this pull request Oct 25, 2014
Closed
@lorenzhs lorenzhs force-pushed the buffer-history branch 2 times, most recently from 77a2c47 to c83669b Compare December 20, 2014 11:33
@cormier
Copy link
Member

cormier commented Jan 2, 2015

@lorenzhs Looks good to me. Cannot really test ALT-> ALT-< with my QWERTY though. I've made some minor changes to the code. You can see them in my commits, and i'll let you merge the branch if you think that they're good.

@cormier cormier force-pushed the buffer-history branch 2 times, most recently from e967441 to 89bd2b2 Compare January 2, 2015 18:43
@lorenzhs
Copy link
Member Author

lorenzhs commented Jan 2, 2015

I can't use Alt+> with Neo2 either, it triggers Alt+G (because > is Mod3+G in neo, where Mod3 is Caps Lock :D)

@lorenzhs
Copy link
Member Author

lorenzhs commented Jan 2, 2015

the last two commits look good, but what's up with the old stuff that got mixed up in here?

@cormier
Copy link
Member

cormier commented Jan 2, 2015

I might have rebased on top of an outdated master ;-)

It's fixed now.

@cormier
Copy link
Member

cormier commented Jan 25, 2015

@lorenzhs what do you think of this? should we merge?

@lorenzhs
Copy link
Member Author

is there any interest in reviving this?

@azizLIGHT
Copy link

Please merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweaking behavior of alt-a
3 participants
@lorenzhs @cormier @azizLIGHT