Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Rubocop to 1.15 #1519

Merged
merged 11 commits into from
May 24, 2021
Merged

Upgrade Rubocop to 1.15 #1519

merged 11 commits into from
May 24, 2021

Conversation

teceler
Copy link
Collaborator

@teceler teceler commented May 23, 2021 •
edited

Depends on #1518

  • Upgrades rubocop to 1.15.0
  • Upgrades rubocop-performance to 1.11.3
  • Upgrades rubocop-rails to 2.10.1
  • Upgrades rubocop-rspec to 2.3.0
     

New (enabled) cops:

  • Gemspec/DateAssignment
  • Layout/SpaceBeforeBrackets
  • Lint/AmbiguousAssignment
  • Lint/DeprecatedConstants
  • Lint/DuplicateBranch
  • Lint/DuplicateRegexpCharacterClassElement
  • Lint/EmptyBlock
  • Lint/EmptyClass
  • Lint/LambdaWithoutLiteralBlock
  • Lint/NoReturnInBeginEndBlocks
  • Lint/NumberedParameterAssignment
  • Lint/OrAssignmentToConstant
  • Lint/RedundantDirGlobSort
  • Lint/SymbolConversion
  • Lint/ToEnumArguments
  • Lint/TripleQuotes
  • Lint/UnexpectedBlockArity
  • Lint/UnmodifiedReduceAccumulator
  • Style/ArgumentsForwarding
  • Style/CollectionCompact
  • Style/DocumentDynamicEvalDefinition
  • Style/EndlessMethod
  • Style/HashConversion
  • Style/HashExcept
  • Style/IfWithBooleanLiteralBranches
  • Style/NegatedIfElseCondition
  • Style/NilLambda
  • Style/RedundantArgument
  • Style/StringChars
  • Style/SwapValues
  • Performance/MapCompact

Throne3d
Throne3d reviewed May 23, 2021
View reviewed changes
.rubocop.yml Show resolved Hide resolved
Throne3d
Throne3d approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@Throne3d Throne3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK beyond the comments! We can always tweak the lints as we go, if they get in our way – I haven't checked them out in much detail

@teceler teceler enabled auto-merge May 24, 2021 01:39
@teceler teceler merged commit b6d776f into master May 24, 2021
@teceler teceler deleted the upgrade/rubocop branch May 24, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Throne3d Throne3d Throne3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teceler @Throne3d