Feature: Add LogOperations to execution hooks #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 69.28% 69.55% +0.26%
==========================================
Files 44 45 +1
Lines 4295 4332 +37
Branches 1047 1051 +4
==========================================
+ Hits 2976 3013 +37
Misses 1108 1108
Partials 211 211
|
Names now match the names of the hook triggers. We also rename the install_hooks to specify that it installs hooks project wide.
The call method is confusing as it only applies to projects but hooks can be project or operation wide.
Allow for the correct passing of the project to install the hooks for.
Assumes that we are using different log files in LogOperation tests.
b-butler
requested review from
b-butler and
SchoeniPhlippsn
and removed request for
a team and
b-butler
…when I tested the example.
@vyasr It's waiting on a review. @kidrahahjo If you have time, could you take a look at this PR again? |
bdice
reviewed
Jun 22, 2023
csadorf
reviewed
Jun 26, 2023
flow/hooks/log_operations.py
Outdated
Comment on lines
63
to
64
| # Do something | ||
|
|
There was a problem hiding this comment.
Since many users typically just copy any example code verbatim, this is meant to emphasize that without a Project definition, nothing would actually happen. So an alternative would be to add at least one "hello world" operation to the example or make this comment a bit clearer, e.g., # Project operation definitions ...".
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 3.3.2 to 3.3.3. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v3.3.2...v3.3.3) --- updated-dependencies: - dependency-name: pre-commit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ruamel-yaml](https://sourceforge.net/p/ruamel-yaml/code/ci/default/tree) from 0.17.31 to 0.17.32. --- updated-dependencies: - dependency-name: ruamel-yaml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.3.1 to 7.4.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.3.1...7.4.0) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/asottile/pyupgrade: v3.3.1 → v3.8.0](asottile/pyupgrade@v3.3.1...v3.8.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
b-butler
force-pushed
the
feature/hooks-LogOperation
branch
from
f4190f9
to
6287212
Compare
b-butler
reviewed
Oct 13, 2023
b-butler
force-pushed
the
feature/hooks-LogOperation
branch
from
2132486
to
672726b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add builtin logging for execution hooks.
Description
Add
LogOperationsand tests forLogOperationsto execution hooks.Motivation and Context
Provides built in logging hooks for users. Partially addresses #637 and #508.
Checklist: