Add pre-commit configuration

[joaander]

Description

Replace existing style checks with pre-commit configuration file.

Motivation and context

Pre-commit is popular.

Using fresnel as a test before making the change in HOOMD.

Checklist:

• I have reviewed the Contributor Guidelines.
• I agree with the terms of the Fresnel Contributor Agreement.
• My name is on the list of authors.

[joaander]

@bdice I adapted your pre-commit configuration for HOOMD and tested on fresnel (I wanted to test on a smaller repository where I could run the formatters first). Have a look.

I switched to using conda to install clang-format and combined it into the main pre-commit configuration file using a manual trigger. #127 applies the autoformatters.

[bdice]

Nice! I had a couple minor questions but otherwise LGTM.

[joaander]

Well, so much for the manual configuration. pre-commit.ci runs those as well, which fails because the runner doesn't hae conda: https://results.pre-commit.ci/run/github/147663951/1620140732.FzOJofjYSs-tTNYab50BHw

I'll move that config to a separate file as you do in freud for now.

[bdice]

Well, so much for the manual configuration. pre-commit.ci runs those as well, which fails because the runner doesn't hae conda: https://results.pre-commit.ci/run/github/147663951/1620140732.FzOJofjYSs-tTNYab50BHw

I'll move that config to a separate file as you do in freud for now.

@joaander You can skip it! https://pre-commit.ci/#configuration-skip

ci:
    skip: [clang-format]

[joaander]

@joaander You can skip it! https://pre-commit.ci/#configuration-skip

ci:
    skip: [clang-format]

Excellent find, I'll do that.

[bdice]

@joaander With the power of teamwork and enough time, we will read all of the documentation. 😆

[joaander]

It still seems to try installing the environment :( - https://results.pre-commit.ci/run/github/147663951/1620141512.9i1t5SAyQD6inHgCJ_hhlw

[joaander]

It still seems to try installing the environment :( - https://results.pre-commit.ci/run/github/147663951/1620141512.9i1t5SAyQD6inHgCJ_hhlw

This is a known and fixed issue: pre-commit-ci/issues#53
pre-commit/pre-commit#1875
Maybe the fix isn't deployed yet?

[bdice]

Maybe the fix isn't deployed yet?

Yup. v2.12.1 came out 18 days ago, and that PR was merged 15 days ago.