Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.33.0 year in CHANGELOG.md #2087

Merged
merged 1 commit into from Nov 18, 2023
Merged

Fix 0.33.0 year in CHANGELOG.md #2087

merged 1 commit into from Nov 18, 2023

Conversation

strohel
Copy link
Contributor

@strohel strohel commented Nov 16, 2023

@est31 thanks for cutting the release!

Could you please also push a git tag from 0.33 and maybe also create a GitHub release from it? Thanks! CC @bschwind.

@est31 est31 merged commit 968fc92 into glium:master Nov 18, 2023
7 checks passed
@est31
Copy link
Collaborator

est31 commented Nov 18, 2023

tag created. I'm not sure a github release is useful.

@strohel strohel deleted the fix-0.33-year branch November 19, 2023 09:00
@strohel
Copy link
Contributor Author

strohel commented Nov 19, 2023

@est31 thank you! BTW I'm not seeing the tag in https://github.com/glium/glium/tags, you may need to push it using git push origin v0.33.0.

The only thing the GitHub release is useful is perhaps showing up-to-date version in the Releases section of the GitHub sidebar:
image
But that's really minor.

@est31
Copy link
Collaborator

est31 commented Nov 19, 2023

I actually pushed it to origin (the fork under my personal account), the issue was that I had to push it to upstream which is how I call the glium/glium remote. Pushed it also to upstream. Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants