Added support for 1,2,3-component textures #1731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@katyo Seems there are merge conflicts. Would you be interested in fixing these? |
katyo
force-pushed
the
support-for-1-2-3-component-textures
branch
from
16960d1
to
895792e
Compare
|
@avl I rebased this PR, so it has to be ready for merge now. |
|
Thanks for the PR. It has a bunch of whitespace/formatting changes. Can you undo them? Then I can give it a review. |
|
@est31 Seems glium doesn't use autoformatting of Rust code. My editing mode does it. |
Setting appropriate texture format: * GL_RED for one component * GL_RG for two component * GL_RGB for three component * GL_RGBA for four component
katyo
force-pushed
the
support-for-1-2-3-component-textures
branch
from
895792e
to
58311b7
Compare
|
@est31 I'm not sure but seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting appropriate texture format:
Quick fix for #1730.