Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backend.is_current assertion #1724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanFlurry
Copy link

Originally added in this commit, we can't always assert that backend.is_current is true after backend.make_current is called The issue seems to be an issue specifically on the later versions of macOS – likely specifically in Mojave. For more information, see this issue.

@tomaka
Copy link
Member

tomaka commented Feb 2, 2019

If this hack is needed, I would prefer to put it in glutin instead.

@fschutt
Copy link
Contributor

fschutt commented Feb 9, 2019

At least from what I can see in azul (since this check was removed in azuls version of glium) the check doesn't seem to do anything. The apps seem to run fine, even when backend.is_current evaluates to false. So I think it is just unnecessary and should be removed (although I'm not sure why it doesn't work specifically on Mojave, maybe there is some kind of buffering of driver commands going on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants