New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Buffers rework #1371
Open
tomaka
wants to merge
21
commits into
master
Choose a base branch
from
buffers-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Buffers rework #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
force-pushed
the
buffers-rework
branch
5 times, most recently
from
December 26, 2015 14:32
c533d92
to
70be45c
Compare
tomaka
force-pushed
the
buffers-rework
branch
from
January 10, 2016 12:23
571cad4
to
c68220d
Compare
tomaka
force-pushed
the
buffers-rework
branch
2 times, most recently
from
January 12, 2016 10:39
7817caf
to
d5550c0
Compare
tomaka
force-pushed
the
buffers-rework
branch
from
January 12, 2016 16:37
d5550c0
to
b52a811
Compare
Are you still working on this? |
No :-/ As I said I'm thinking of reorienting glium towards a more OpenGL 2-OpenGL 3-based experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1325
VerticesSource
andIndicesSource
private.Buffer
betweenDynamicBuffer
,ImmutableBuffer
andPersistentBuffer
.BufferAny
types.PersistentBuffer
to aSyncPersistentBuffer
(Sync but not Send) for multithreaded reading and writing.This also changes how the specializations work.
Instead of being full wrappers, types such as
VertexBuffer
orPixelBuffer
are not templated. For example instead ofIndexBuffer<T>
you will now haveIndexStorage<Buffer<[T]>>
, so that it can be adapted to all other underlying buffer types. Old type names will still be provided as aliases, so this shouldn't break anything.This is a breaking change because:
VerticesSource
andIndicesSource
are now private.persistent
,immutable
,empty_persistent
,empty_immutable
are removed in favor ofnew
andempty
on the new types.