Updating glimmer-vm to 0.73.0 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragpat
force-pushed
the
glimmer-vm-bump
branch
from
73efef2
to
13e58b7
Compare
pzuraq
approved these changes
Dec 21, 2020
| * | ||
| * The CompileTimeResolver is responsible for registering everything but root | ||
| * components, which is why `registry` is public, for ease of access. | ||
| * Resolution for non built ins is now handled by the vm as we are using strict mode | ||
| */ | ||
| export class RuntimeResolver implements VMRuntimeResolver { |
There was a problem hiding this comment.
We should look into making these optional now tbh
|
|
||
| if (DEBUG) { | ||
| createTemplate = (): CustomSerializedTemplate => { | ||
| createTemplate = (): SerializedTemplateWithLazyBlock => { |
There was a problem hiding this comment.
We should probably rename/alias this to precompileTemplate, to match the original RFC. We can do that in a follow on, just noting for the 2.0 release.
| template: SerializedTemplateWithLazyBlock, | ||
| ComponentClass: object | ||
| ): object { | ||
| return vmSetComponentTemplate(templateFactory(template), ComponentClass); |
There was a problem hiding this comment.
we should likely update babel transforms to make this unnecessary, the VM version matches the public API version in Ember, so it'd be good to make sure they stay aligned. Again, fine to do in a followup, and if the motivation is to save bytes we could expose a different compile-target function that does this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How