Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/rename wrapper around setComponentTemplate #326

Open
pzuraq opened this issue Dec 21, 2020 · 0 comments
Open

Remove/rename wrapper around setComponentTemplate #326

pzuraq opened this issue Dec 21, 2020 · 0 comments

Comments

@pzuraq
Copy link
Member

pzuraq commented Dec 21, 2020

Currently, we wrap the VM's version of setComponentTemplate with a function that calls templateFactory on the serialized template block. This means the transform can be simpler overall, and we import one fewer function in each module, saving bytes, but it does not match the implementation in Ember, which requires us to pass in the template factory. We should either remove this wrapping layer and do it in the Babel transform, or we should rename it and export it as a separate utility function that the Babel transform can target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant