Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security audit handlebars update #919

Merged
merged 5 commits into from
Feb 15, 2019
Merged

Conversation

knownasilya
Copy link
Contributor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to update

"handlebars": "^4.0.6",

and the top level yarn.lock, in addition I believe that you will need to remove @types/handlebars (because handlebars@4.1.0 includes its own types).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@knownasilya
Copy link
Contributor Author

@rwjblue thanks added

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linting failure requires removing @types/handlebars (because handlebars@4.1.0 brings its own types and TS errors on duplicates).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sorry for the run around here, I don't think the yarn.lock is updated in this PR? Would you mind doing a quick yarn...

@knownasilya
Copy link
Contributor Author

knownasilya commented Feb 15, 2019

Having trouble with yarn in syntax package:

error An unexpected error occurred: "https://registry.yarnpkg.com/@glimmer%2flocal-debug-flags: Not found".

trying to reinstall yarn..

@rwjblue rwjblue merged commit f072d29 into glimmerjs:master Feb 15, 2019
@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2019

Thank you @knownasilya!

@knownasilya knownasilya deleted the patch-1 branch February 15, 2019 22:37
@rwjblue rwjblue added the bug label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants