-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: security audit handlebars update #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to update
Line 44 in fca7da1
"handlebars": "^4.0.6", |
and the top level yarn.lock, in addition I believe that you will need to remove @types/handlebars (because handlebars@4.1.0 includes its own types).
@rwjblue thanks added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linting failure requires removing @types/handlebars (because handlebars@4.1.0 brings its own types and TS errors on duplicates).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very sorry for the run around here, I don't think the yarn.lock
is updated in this PR? Would you mind doing a quick yarn
...
Having trouble with yarn in syntax package:
trying to reinstall yarn.. |
Thank you @knownasilya! |
https://www.npmjs.com/advisories/755