Ensure dynamic component invocations follow splattribute rules. #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| 'invoking curried component with attributes via angle brackets (invocation attributes clobber)'() { | ||
| this.registerHelper('hash', (_positional, named) => named); | ||
| this.registerComponent('Glimmer', 'Foo', '<p data-foo="default"...attributes>hello world!</p>'); |
There was a problem hiding this comment.
nitpicking: space between "default" and ...attributes
When the `DynamicComponent` opcode was initial introduce, it did not properly replicate the `SetComponentAttrs` toggling system that `Ops.Component` has. This has the unfortunate result of making dynamic component invocations not follow the established rules for splattributes (invocation "wins" for all attributes other than `class` and `class` is merged). In this context `DynamicComponent` is specifically referring to angle bracket invocation with either a named argument or path.
rwjblue
force-pushed
the
fix-dynamic-component-splattributes
branch
from
f370f2d
to
e1334ae
Compare
krisselden
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
DynamicComponentopcode was initial introduce, it did not properly replicate theSetComponentAttrstoggling system thatOps.Componenthas. This has the unfortunate result of making dynamic component invocations not follow the established rules for splattributes (invocation "wins" for all attributes other thanclassandclassis merged). The implementation here for attrs block created here, is directly taken from theOps.Componentopcode just below...In this context
DynamicComponentis specifically referring to angle bracket invocation with either a named argument or path.Once merged, this needs to be backported into the version of glimmer-vm in use by Ember 3.4.x to fix the bug reported by @cibernox in emberjs/ember.js#16933 and rwjblue/sparkles-component#7.