add tracked utilities for ember-inspector #1489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
tracked-utils
branch
2 times, most recently
from
25ec20f
to
6e4232b
Compare
|
@NullVoxPopuli can we have this? |
|
Maybe, i'm behind an getting the VM integrated in to ember, so that's blocking me actually reviewing all these prs. At first glance though, does this need to be in production? Can we instead wrap all the behavior in meta.env? |
|
i think it would be nice to have it in prod as well. |
patricklx
force-pushed
the
tracked-utils
branch
4 times, most recently
from
e403516
to
80c34c3
Compare
patricklx
force-pushed
the
tracked-utils
branch
2 times, most recently
from
4cc0bff
to
e4a3192
Compare
patricklx
changed the title
patricklx
force-pushed
the
tracked-utils
branch
4 times, most recently
from
0e05372
to
79fa4e6
Compare
patricklx
force-pushed
the
tracked-utils
branch
from
79fa4e6
to
3318240
Compare
|
@chancancode can you have a look at this? At least i would like the object/property info on the tag for inspector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we do not need to do this hack:
https://github.com/emberjs/ember-inspector/blob/8c4cd42a50b614981f8b863dfe07e116ced04953/ember_debug/object-inspector.js#L41