Enable publish retrying #1458

NullVoxPopuli · 2023-10-24T03:03:35Z

logic stolen from: https://github.com/embroider-build/embroider/blob/main/test-packages/unstable-release/publish.js

it's really only an issue if we do what we're doing right now where we try to publish the same tag over and over again due to config issues (or infra issues)

Changes

This removed yalc-publish.mts, which appears to be leftover from before the pnpm migration. yalc used npm publish, which doesn't support workspace:^ versions.
in the bin package, swap esno for esyes, because we like positivity. Also, esyes doesn't compile to CJS like esno does.
- esyes is in use by the starbeam family of projects
- this required upgrading local node to v21
A New pnpm-publish.mts file is present, which implements iterate + try/catch for each package so that our workflow_dispatch way of deploying packages can work eventually.

Testing

Testing locally with:

cd bin
pnpm esyes ./pnpm-publish.mts

shows, since my npm user doesn't have access to publish (intentionally!):

❯ pnpm esyes ./pnpm-publish.mts 
# publishing @glimmer/compiler
Publishing @glimmer/compiler has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/debug
Publishing @glimmer/debug has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/destroyable
Publishing @glimmer/destroyable has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/dom-change-list
Publishing @glimmer/dom-change-list has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/encoder
Publishing @glimmer/encoder has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/global-context
Publishing @glimmer/global-context has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/interfaces
Publishing @glimmer/interfaces has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/local-debug-flags
Publishing @glimmer/local-debug-flags has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/manager
Publishing @glimmer/manager has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/node
Publishing @glimmer/node has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/opcode-compiler
Publishing @glimmer/opcode-compiler has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/owner
Publishing @glimmer/owner has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/program
Publishing @glimmer/program has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/reference
Publishing @glimmer/reference has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/runtime
Publishing @glimmer/runtime has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/syntax
Publishing @glimmer/syntax has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/util
Publishing @glimmer/util has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/validator
Publishing @glimmer/validator has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/vm
Publishing @glimmer/vm has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/vm-babel-plugins
Publishing @glimmer/vm-babel-plugins has failed. A full list of errors will be printed at the end of this run
# publishing @glimmer/wire-format
Publishing @glimmer/wire-format has failed. A full list of errors will be printed at the end of this run

# bunch more error logs
npm ERR! A complete log of this run can be found in: /home/nullvoxpopuli/.npm/_logs/2023-10-24T03_02_16_643Z-debug-0.log
npm notice 
npm notice 📦  @glimmer/vm-babel-plugins@0.85.2
npm notice === Tarball Contents === 
npm notice 1.9kB .turbo/turbo-build.log                  
npm notice 1.1kB LICENSE                                 
npm notice 510B  README.md                               
npm notice 1.1kB dist/index.cjs                          
npm notice 2.3kB dist/index.cjs.map                      
npm notice 242B  dist/index.d.cts                        
npm notice 252B  dist/index.d.cts.map                    
npm notice 241B  dist/index.d.ts                         
npm notice 251B  dist/index.d.ts.map                     
npm notice 874B  dist/index.js                           
npm notice 2.4kB dist/index.js.map                       
npm notice 1.1kB index.ts                                
npm notice 956B  package.json                            
npm notice 105B  rollup.config.mjs                       
npm notice 105B  test/fixtures/basic/.babelrc.js         
npm notice 229B  test/fixtures/basic/code.js             
npm notice 244B  test/fixtures/basic/output.js           
npm notice 129B  test/fixtures/explicit-false/.babelrc.js
npm notice 229B  test/fixtures/explicit-false/code.js    
npm notice 247B  test/fixtures/explicit-false/output.js  
npm notice 128B  test/fixtures/explicit-true/.babelrc.js 
npm notice 229B  test/fixtures/explicit-true/code.js     
npm notice 244B  test/fixtures/explicit-true/output.js   
npm notice 796B  test/index.js                           
npm notice === Tarball Details === 
npm notice name:          @glimmer/vm-babel-plugins               
npm notice version:       0.85.2                                  
npm notice filename:      glimmer-vm-babel-plugins-0.85.2.tgz     
npm notice package size:  4.9 kB                                  
npm notice unpacked size: 15.9 kB                                 
npm notice shasum:        a90a92627c979309003ac39ecbfc47bb0da57a89
npm notice integrity:     sha512-pS9lu40pgET3w[...]9LVwZZ/LH0v3Q==
npm notice total files:   24                                      
npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@glimmer%2fvm-babel-plugins - Not found
npm ERR! 404 
npm ERR! 404  '@glimmer/vm-babel-plugins@0.85.2' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in: /home/nullvoxpopuli/.npm/_logs/2023-10-24T03_02_17_612Z-debug-0.log
npm notice 
npm notice 📦  @glimmer/wire-format@0.85.2
npm notice === Tarball Contents === 
npm notice 1.9kB  .turbo/turbo-build.log
npm notice 1.1kB  LICENSE               
npm notice 2.9kB  dist/index.cjs        
npm notice 12.0kB dist/index.cjs.map    
npm notice 3.6kB  dist/index.d.cts      
npm notice 847B   dist/index.d.cts.map  
npm notice 3.6kB  dist/index.d.ts       
npm notice 846B   dist/index.d.ts.map   
npm notice 2.6kB  dist/index.js         
npm notice 12.0kB dist/index.js.map     
npm notice 1.6kB  index.ts              
npm notice 3.8kB  lib/opcodes.ts        
npm notice 1.0kB  lib/resolution.ts     
npm notice 577B   lib/well-known.ts     
npm notice 746B   package.json          
npm notice 105B   rollup.config.mjs     
npm notice === Tarball Details === 
npm notice name:          @glimmer/wire-format                    
npm notice version:       0.85.2                                  
npm notice filename:      glimmer-wire-format-0.85.2.tgz          
npm notice package size:  7.9 kB                                  
npm notice unpacked size: 49.1 kB                                 
npm notice shasum:        345d05786ccb348ef824a25206b4516d69ccf062
npm notice integrity:     sha512-JQCdnzIPP6H4g[...]fo9WPSKQxy2dg==
npm notice total files:   16                                      
npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@glimmer%2fwire-format - Not found
npm ERR! 404 
npm ERR! 404  '@glimmer/wire-format@0.85.2' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

…the end

…moduleregisterspecifier-parenturl-options

NullVoxPopuli · 2023-10-24T03:06:40Z

bin/package.json

@@ -2,27 +2,30 @@
  "name": "@glimmer-workspace/bin",
  "private": true,
  "dependencies": {
-    "puppeteer-chromium-resolver": "^20.0.0",


running pnpm <anything> sorts the package.json

NullVoxPopuli · 2023-10-24T03:18:57Z

bin/yalc-publish.mts

-
-for (const pkg of packages('@glimmer')) {
-  console.log(`${chalk.gray('# publishing')} ${chalk.cyanBright(pkg.name)}`);
-  execSync('yalc publish --push', {


yalc wasn't even a dependency anywhere

NullVoxPopuli added 6 commits October 23, 2023 22:46

Steal from embroider for publish retrying / aggregating errors until …

9ccf23a

…the end

use esyes instead of esno. positivity is better

71fcb4f

extend volta config

9c91d2c

To use esyes, we need node 21 for https://nodejs.org/api/module.html#…

158dd0a

…moduleregisterspecifier-parenturl-options

Better logging

e2ef853

Remove unneeded comments

93cad66

NullVoxPopuli commented Oct 24, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable publish retrying #1458

Enable publish retrying #1458

NullVoxPopuli commented Oct 24, 2023 •

edited

NullVoxPopuli Oct 24, 2023

NullVoxPopuli Oct 24, 2023

Enable publish retrying #1458

Are you sure you want to change the base?

Enable publish retrying #1458

Conversation

NullVoxPopuli commented Oct 24, 2023 • edited

Changes

Testing

NullVoxPopuli Oct 24, 2023

Choose a reason for hiding this comment

NullVoxPopuli Oct 24, 2023

Choose a reason for hiding this comment

NullVoxPopuli commented Oct 24, 2023 •

edited